search

jcelliott / turnpike

Go implementation of a WAMP (Web Application Messaging Protocol) client and router
MIT License
258 stars 88 forks source link

Implement RPC functions for client #48

Closed jcelliott closed 10 years ago

josephschorr commented 10 years ago

Hey guys,

Any status update on this feature? If no, are there any requirements/restrictions if I decide to implement the basics of RPC (REGISTER and CALL)?

jcelliott commented 10 years ago

I was planning on getting to it later this week. Glad to have other people help though, so If you do want to work on it let me know. The only requirements are to use gofmt and to have a basic test for it.

josephschorr commented 10 years ago

I'm planning to work on it on Friday, so let me know if you get around to it before then. If not, I'll take a stab then.

josephschorr commented 10 years ago

@jcelliott: I just saw this fork when starting my own: https://github.com/AnimationMentor/turnpike/blob/wamp-2/client.go

Is there a reason it isn't merged in?

jcelliott commented 10 years ago

The code that link points to is part of Turnpike v1, targeting WAMP v1. I'm not sure why it's on the wamp-2 branch in that fork. This issue is specifically for adding this functionality for WAMP v2. Which version of WAMP are you using?

josephschorr commented 10 years ago

I'm planning to use WAMP v2. As you point out, despite its name, it does appear to be a fork of the WAMP v1 client, so I'll continue with my plans to fork the v2 and add RPC there.

jcelliott commented 10 years ago

Started in bfca50332d6dd5524ff6c1cde8545e3824ad6fcd

josephschorr commented 10 years ago

Continued in https://github.com/jcelliott/turnpike/commit/6ad6cd9b79ae8c28fdbfa27c4ad4b705851f347b

josephschorr commented 10 years ago

Anything else you'd like me to add for this issue?

jcelliott commented 10 years ago

Nope, it looks good. I'm doing some refactoring as part of implementing client side auth, and I'll close this issue after that's complete.

jcelliott commented 10 years ago

@josephschorr Let me know if the changes I made will not work for your use case.