search

jcesarmobile / FilePicker-Phonegap-iOS-Plugin

This plugin makes possible to pick files from iCloud or other document providers
MIT License
50 stars 51 forks source link

Support cordova-cli 9.0.0 - requireCordovaModule deprecation #56

Closed tombell closed 5 years ago

tombell commented 5 years ago

The use of context.requireCordovaModule for non-cordova dependencies has been removed, and suggests you now add the dependency to the plugins package.json and require'd normally.

https://github.com/apache/cordova-lib/pull/707

jcesarmobile commented 5 years ago

That's used in the hook, the fix should be to just remove the whole hook and use edit-config or config-file tags to write on the entitlement plist files. I was waiting for cordova-ios 5.0.0 as it was going to use .entitlements files instead of the .plist files, but that wasn't implemented in the end and took longer than I expected.

Closing as there is another issue for that https://github.com/jcesarmobile/FilePicker-Phonegap-iOS-Plugin/issues/48

tombell commented 5 years ago

Thanks for the comment @jcesarmobile 👍

jcesarmobile commented 5 years ago

As an user has send a PR I've published 1.1.6 with the fix Will remove the hook in a next major version