search

jcgay / maven-profiler

Log Maven mojos execution time
MIT License
113 stars 20 forks source link

Bug: hideParameters has inverted logic #224

Open cgm-aw opened 1 month ago

cgm-aw commented 1 month ago

Hi!

first things first: I really like your plugin and think it's very helpful :)

However, I noticed that the parameter hideParameters is buggy. Basically, its logic is inverted: State Now Should
Omitted Without report Without report
True With report Without report
False Without report With report

I took the liberty of creating a bugfix branch for this: https://github.com/jcgay/maven-profiler/pull/225

Please take a look at it. I explicitly left the behavior alone when you omit the parameter to not cause surprises.

Best regards

jcgay commented 1 month ago

Thanks for the kind words 😇.

I'll have a look at the PR in the next days, thank you for your contribution 👍