search

jcgoette / baby_buddy_homeassistant

This custom integration provides sensors for Baby Buddy API endpoints.
MIT License
59 stars 26 forks source link

Expired timers are no longer returned by the API #109

Closed Cadair closed 1 year ago

Cadair commented 1 year ago

This seems to fix #108 for me

The related change in babybuddy is: https://github.com/babybuddy/babybuddy/commit/7b7f17fde6cc6c45a36752cbf1b2752fe396476d

What's the best way to handle supporting both <2 and 2 at the same time?

Cadair commented 1 year ago

@jcgoette Looks like the final release of 2.0 isn't that far away, have you had a chance to look at this?

The only thing I haven't done with it is tested it against a 1.x release.

jcgoette commented 1 year ago

Yes, this looks good to me. If you can test against v1.x.x, should be good to go.

Cadair commented 1 year ago

Not sure when i will get around to spinning up a test instance. If anyone has one they could test against that would be super useful.

jcgoette commented 1 year ago

Did some prelim testing on pre- and post- v2.0 and looks good to me. My only thought is should we remove the Timers sensor now, since completed sensors are now deleted?

Cadair commented 1 year ago

I think the _last_timer sensor is now pretty much a duplication of the attributes of the switch?