search

jcgoette / baby_buddy_homeassistant

This custom integration provides sensors for Baby Buddy API endpoints.
MIT License
59 stars 26 forks source link

Update 'async_add_pumping' for BB v2 API #121

Open seanhagen opened 11 months ago

jcgoette commented 11 months ago

Thanks for taking a swing at this!

Make sure to black your code.

seanhagen commented 11 months ago

No problem! Python is similar enough to Go I felt I could take a stab at it 😅

jcgoette commented 10 months ago

Sorry it has taken me so long to review and respond.

I tried testing this and couldn't get it to work - have you tested this successfully?

Looking more closely at the API, it does now allow an end parameter, but does not have timer (not sure why). So, I think you're going to have to either:

  1. Implement this in sensor.py
  2. Create a PR in BB repo to add timer parameter to pumping API
jcgoette commented 9 months ago

@seanhagen have you had a chance to review again?

seanhagen commented 9 months ago

Sorry, been busy -- 2 month old baby doesn't leave me with much time for this kind of stuff outside of work 😅. I'll try to take a look this week though.