search

jcgoette / baby_buddy_homeassistant

This custom integration provides sensors for Baby Buddy API endpoints.
MIT License
64 stars 30 forks source link

Remove likely unnecessary default_name, fixes broken 2023.9 #131

Closed gagebenne closed 1 year ago

gagebenne commented 1 year ago

Closes #119.

Could add child slug (Baby Buddy API unique identifier) in case you want more unique identifiers.

jcgoette commented 1 year ago

This works (for whatever reason??), but let's change to name instead of removing completely.

gagebenne commented 1 year ago

Yeah, wasn't sure if name had to be unique for devices, but makes more sense to be human readable first, last. Also -- did you still want Baby prefixing the sensor device name?

jcgoette commented 1 year ago

Ha, yea, I just noticed sensor.py had "Baby" prefix and switch.py didn't. I don't feel strongly either way and I think it will either break nothing or break things equally.

gagebenne commented 1 year ago

Ha, yea, I just noticed sensor.py had "Baby" prefix and switch.py didn't. I don't feel strongly either way and I think it will either break nothing or break things equally.

Just ran these changes, nothing seemed to break in my setup!

jcgoette commented 1 year ago

I meant by changing both to be consistent. Which we should do.