jcgoette / baby_buddy_homeassistant

This custom integration provides sensors for Baby Buddy API endpoints.
MIT License
64 stars 30 forks source link

Update sensor add pumping to provide start and end #143

Closed kylebjordahl closed 7 months ago

kylebjordahl commented 9 months ago

Stopgap solution for #122 until #121 is merged.

jcgoette commented 9 months ago

Thanks for taking a stab at this. I do think ideally the timer functionality is implemented in BB itself. That being said, if we keep time vs. start, we can save a breaking change.

20BBrown14 commented 7 months ago

@jcgoette I've been running into the issue described as well. Could we perhaps get this merged? Setting the time on the add_pumping service does nothing as far as I can tell.

kylebjordahl commented 7 months ago

This issue and others caused our family to switch from BB to Nara, so I'll close this for now since I won't put any more time into it, but feel free to reopen and merge if you want it @jcgoette