jchambers / pushy-console

A simple GUI app for sending APNs (iOS/macOS/Safari) push notifications
MIT License
53 stars 18 forks source link

Make a executable jar #15

Closed bazi closed 5 years ago

bazi commented 5 years ago

This PR makes a executable jar by copying dependencies into one directory and setting appropriate MANIFEST file for the jar.

It feels to me executing a jar is more straightforward than running maven exec goals.

P.S. maven shade plugin could be used to generate an uber-jar but due to BouncyCastle dependency it fails with "Invalid signature..." errors.

jchambers commented 5 years ago

An excellent suggestion. Thanks for the contribution!

maven shade plugin could be used to generate an uber-jar but due to BouncyCastle dependency it fails with "Invalid signature..." errors.

Could you please file a separate issue for that?