search

jchambers / pushy-console

A simple GUI app for sending APNs (iOS/macOS/Safari) push notifications
MIT License
53 stars 18 forks source link

Create uber jar #16

Closed bazi closed 5 years ago

bazi commented 5 years ago

As pushy-console is kind of a utility tool it would be nice to have it as one single file for easier sharing and running. I tried to make an uber jar with maven shade plugin but faced "Invalid signature..." errors due to signed BouncyCastle jars.

For now, I created a PR #15 that copies dependencies into one place and configures MANIFEST of pushy-console jar to make it executable as jar.

jchambers commented 5 years ago

@bazi Could you clarify what would be different between an "uber jar" and what you've done in #15?

jchambers commented 5 years ago

Scratch that—I figured it out. #15 assembles all of the dependencies in a lib directory, but doesn't include them in the jar itself.

jchambers commented 5 years ago

I found this: http://zhentao-li.blogspot.com/2012/06/maven-shade-plugin-invalid-signature.html

It feels a little like copying/pasting a magic voodoo spell into our POM, but it does get the job done. I'll open a pull request for more detailed discussion.