search

jchambers / pushy-console

A simple GUI app for sending APNs (iOS/macOS/Safari) push notifications
MIT License
53 stars 18 forks source link

#19 - Fix issue with I18N #20

Closed coelle closed 5 years ago

coelle commented 5 years ago

Java tries to load the properties with the "language extension" which matches the current system: "If still no result bundle is found, the base name alone is looked up." See https://docs.oracle.com/javase/7/docs/api/java/util/ResourceBundle.html

jchambers commented 5 years ago

First and foremost, thank you for the contribution! While we only have one language, does it make more sense to rename the existing English-specific .properties file to be non-locale-specific rather than introducing a new copy?

coelle commented 5 years ago

As long as there is only one language, having only the base .properties file is ok. But for issue #14 you should maintain the copied file...

jchambers commented 5 years ago

Makes sense. How about a symlink, though?

coelle commented 5 years ago

Seems legit. I tried it by solving #14 for german (see pull request #21) ;-)

coelle commented 5 years ago

May be you should drop this pull request and accept #21 instead.

coelle commented 5 years ago

The symlink solution might raise issues. I opened pull request #22 with an updated solution.