search

jchambers / pushy-console

A simple GUI app for sending APNs (iOS/macOS/Safari) push notifications
MIT License
54 stars 20 forks source link

Add docker setup + correct some typos #32

Open mdeweerd opened 2 years ago

mdeweerd commented 2 years ago

This add docker configuration files so that essentially docker compose run pushy-console and a local XServer is all that is needed to run the application.

Also fixed some typos identified with codespell.

jchambers commented 2 years ago

Hello, and thank you for the contribution!

I'm a little confused about the Docker thing; why is that necessary? Is mvn javafx:run not working for you? Why does adding Docker and a local XServer an improvement over the status quo?

mdeweerd commented 2 years ago

I use windows and did not want to set up mvn or fight with getting the right java version in the path or getting it to work properly on windows (maybe it does, but there's many projects that do not).

I have Docker, a local XServer and it's mainly an environment that can be easily reproduced. Once done, the container/images just need to be deleted and not bother anything else.

If you don't like it, don't use it. I am just sharing - it's not perfect, but works.