search

jchamet / html-table-sort

Chrome Extension. Add it to your browser to use. Clicking on a table column header <th> will reorder the rows of an HTML table in ascending/descending order.
MIT License
13 stars 9 forks source link

unable to sort tables not using "th", like gerrit changeset tables #8

Closed ssbarnea closed 4 years ago

ssbarnea commented 7 years ago

topic rhos-ci-test code engineering code review 2017-06-14 11-54-33

Can we make it work in this case?

a-raccoon commented 6 years ago

I'm encountering this issue as well. Tables are classically composed of "tr" and "td", I hadn't even heard of "th" before today, and apparently most of the Internet agrees. I can't find a page that this extension works on.

http://www.firelookout.org/lo-newmexico.html

ssbarnea commented 6 years ago

@a-raccoon I have there are lots of people that should RTFD :D

<th> happens to be standard since HTML3 or earler if I am not mistaken. It is still inside HTML5 with no plans to be deprecated and is supported by all browsers, so so excuses other than ignorance for not using it.

a-raccoon commented 6 years ago

Regardless, this browser extension is only as good as it is capable of working on other people's webpages. If it doesn't work on other people's webpages, then it is lacking in usefulness. 90% of the academic and government documentation Internet is still composed of HTML 1.0 standard, and always will be.

TorkelV commented 4 years ago

I opened a pull request to fix this, but doesn't look like there's a lot of activity here.. You could download the source of my PR and add it to chrome manually if you need this feature :) Hopefully it will be added to a new release though

17

jchamet commented 4 years ago

@TorkelV thank you for contributing, PRs are always appreciated! I'll review in the morning. And then let's see what we can do about that new release haha