jchanvfx / NodeGraphQt

Node graph framework that can be re-implemented into applications that supports PySide2
http://chantonic.com/NodeGraphQt/
MIT License
1.27k stars 259 forks source link

Why are there full viewport updates? #431

Open JamesDeAntonis opened 3 weeks ago

JamesDeAntonis commented 3 weeks ago

I noticed here that you have

self.setViewportUpdateMode(QtWidgets.QGraphicsView.FullViewportUpdate)

is it dangerous to set bounding rect viewport update instead?

self.setViewportUpdateMode(QtWidgets.QGraphicsView.BoundingRectViewportUpdate)

When dragging nodes, I noticed the full updates cause like 70 (I think) unnecessary repaints on top of the expected path repaints. This was causing lagginess for me, especially when other animations are happening at the same time