Failed to decrypt message

Nhoya commented 6 years ago

Hi, after i generate the encrypted message i try to decrypt it with gpg -d but it fails with gpg: no valid OpenPGP data found gpg: decrypt_message failed

the encryption is done with

func encryptStuff(person User) {
        fmt.Println(person.stuff)
        key, _ := ioutil.ReadFile(person.keypath)
        pubEntity, _ := pgp.GetEntity(key, []byte{})
        encrypted, _ := pgp.Encrypt(pubEntity, []byte(person.stuff))
        fmt.Println(string(encrypted))
}

jchavannes commented 6 years ago

@Nhoya there seem to be some discrepancies between this pgp library and command line gpg. You are not the first person to run into this.

If encrypting / decrypting both using the library it works fine. I am going to look into what is causing this issue. Thanks for reporting.

woohgit commented 6 years ago

Same issue here.

It is failing with

[wooh@carbonx katsubushiman]$  git:(master) 4M 3A gpg --version
gpg (GnuPG) 2.2.8
libgcrypt 1.8.3
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: /home/wooh/.gnupg
Supported algorithms:
Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
        CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2

woohgit commented 6 years ago

Nah, the issue is that the HEADER/FOOTER should be:

-----BEGIN PGP MESSAGE-----
...
-----END PGP MESSAGE-----

It is easy to change it. Without this lib, with the core opengpg lib it looks like:

// Encrypt encrypts the message
func Encrypt(entity *openpgp.Entity, message []byte) ([]byte, error) {
    // Create buffer to write output to
    buf := new(bytes.Buffer)

    // Create encoder
    encoderWriter, err := armor.Encode(buf, "PGP MESSAGE", make(map[string]string))
    if err != nil {
        return []byte{}, fmt.Errorf("Error creating OpenPGP armor: %v", err)
    }

    encryptorWriter, err := openpgp.Encrypt(encoderWriter, []*openpgp.Entity{entity}, nil, nil, nil)
    if err != nil {
        return []byte{}, fmt.Errorf("Error creating entity for encryption: %v", err)
    }

    messageReader := bytes.NewReader(message)
    _, err = io.Copy(encryptorWriter, messageReader)
    if err != nil {
        return []byte{}, fmt.Errorf("Error writing data to compressor: %v", err)
    }

    encryptorWriter.Close()
    encoderWriter.Close()

    return buf.Bytes(), nil
}

jchavannes commented 6 years ago

Nice find @woohgit

Auguronomics commented 4 years ago

Hi I got the same issue when try to operate Postgres armor() and the encrypted, err := pgp.Encrypt(pubEntity … 1st I go the header and footer failure : PGP MESSAGE 2nd the base 64 encoding line feed occurs at a different position : the go one :

-----BEGIN Message-----

wYwDElIW/5lzPiUBBADepdubA9ii9+kw85nHXbYx7OtBr3rL6lQym0Xwl6ucVuLq
hAoSSdWbChwnfvnli3QHIYW/kdKJ6JiV5/eQxIfJONdh/ZBm2sYrEgpM627YZFUd
V5aoxqCh6kEVZrbG+whGEtqjpgO4G3X3G1dJQRG6/kPqLyjnzGL0MKD1R6Ay79Lg
AeNqA8lvuT/f0eH2M+A/4MnhWD7gkuJ16tB14ArjoSAg4XV54GzgAeFiheB35mak
VE6c7+Sn4K7rb2izxJ0lN7xcTd0Oh9VeTkU91x+xYXwMqatcib1HYj3qfnfNcsim
f318HENZcmezByxPRF/g8uUINyeLw9at5F5rlDjJDe25j3hP6xzVWoJO5PoatO8Q
vOCd4pjHVNfg6eKmGcPe4ILjEnVK9ED7xOngcuSOCz8opQl3zC85K3aY1dfM4k1j
PeHh9WAA
=VzF7
-----END Message-----

versus the Postgres :

Thanks for your attention great job for the lib

jchavannes / go-pgp

Failed to decrypt message #1