jchayan
commented
4 years ago This implementation could be easily upgraded to allow:
- Putting sheets with cookies with different fillings
- Putting multiple sheets in an oven (if we had the oven capacity)
A few notes:
- Since we have a Sheet model as a proxy between the cookies and oven, now the cookie storage polymorphic association is not among Users and Ovens, but among Users and Sheets
- The idea of a polymorphic association in any case is wrong: Assuming that a User and a Oven (or Sheet) are both "storage methods" doesn't make sense for the business logic - not to forget that it violates the Liskov substitution principle. The fact that a User and a Oven or Sheet can have cookies doesn't mean that these 2 objects are polymorphic.
- It is even worse to force the system to have that implementation. Very dared statement here
- As of right now, the only responsibility of the sheet is to act as a proxy but also maps to a table in the database with no purpose at all, probably not the best solution. Besides, it will create a new sheet every time the oven operator cooks cookies. Since the processes for cookie delivery aren't very elaborated, I think it's a decent enough solution for now but I'm open to ideas.
A quick note about the sheet model: We still don't know if there will be a pool of available sheets in the bakery. In that case we could implement an ObjectPool. Or a Singleton if there's only 1 sheet available (which I doubt). In any case, we still don't know. If we get those requirements for the client, we can design the best solution.
Ideas, feedback and criticism are welcome
Issue: #7