search

jchen006 / shenanigans

Recipe hacking
4 stars 0 forks source link

changed drawer to temporary #99

Closed snallapa closed 5 years ago

snallapa commented 5 years ago

Main changes are in navbar. If we tried to render the children like we did before, with {this.props.children} the navigation would be way more jumpy because a user would open it, click on a link and cause the whole page to rerender. Instead since we are using dynamic routing, we can just have the routes inside the navbar and render as necessary creating a way nicer flow.

jchen006 commented 5 years ago

@snallapa looks good to me. You will need to probably .gitignore the bundle.js for now or something since there will be constant merge issues that need to be resolved

snallapa commented 5 years ago

@jchen006 removed bundle from git as honestly should never have been there