search

jcheng31 / DarkSkyApi

An unofficial C# library for the Dark Sky weather service. Targets .NET Standard 1.1.
MIT License
33 stars 18 forks source link

Async / await cleanup #14

Closed IEvangelist closed 8 years ago

IEvangelist commented 8 years ago

Removed unnecessary async / await keywords. For simple Task and Task<T> methods you only need to await if you're using the or relying on the result of the task, in these cases we can simply return the task that will represent the asynchronous operation. Additionally, I removed some redundant this keywords while I was in here.

Additionally, I added the "Async" suffix to one of the methods that was missing it.

IEvangelist commented 8 years ago

@jcheng31 are you no longer active on this repository? I would love to see this pull request make its way into the master branch. Thank you

jcheng31 commented 8 years ago

Still around, just a bit busy :(

This looks good - thanks for catching the missing Async method name, especially - though could you resubmit with it merging into develop? I'll make sure it goes out with the next release, hopefully by this weekend :)

The redundant thiss were intentional since that's how StyleCop has it out of the box, but I've seen enough good arguments elsewhere as to why they should be dropped; will go and prune them elsewhere as well if they're still lurking around.

IEvangelist commented 8 years ago

@jcheng31, done...thanks

jcheng31 commented 8 years ago

Merged the new request - thanks again :)