search

jchibane / if-net

Implicit Feature Network (IF-Net) - Codebase
305 stars 59 forks source link

Questions on voxelized_pointcloud_sampling #10

Closed pengsida closed 3 years ago

pengsida commented 3 years ago

Hi,

I realized that voxelized_pointcloud_sampling creates an occupancy indexed by x, y, z, namely occupancy[x, y, z]: https://github.com/jchibane/if-net/blob/master/data_processing/voxelized_pointcloud_sampling.py#L60 However, this behavior is different from that of F.grid_sample, which indexes the occupancy using occupancy[z, y, x]. Have you noticed this problem?

pengsida commented 3 years ago

I found that when an occupancy is indexed by x, y, z, the input to F.grid_sample should be z, y, x. So the implementation is correct. Thank you!