jchouse / csscomb-atom

MIT License
16 stars 9 forks source link

"lines-between-rulesets" not included #25

Open tomagladiator opened 8 years ago

tomagladiator commented 8 years ago

Hello, Thanks for this plugin,

Can we add this useful rule for SCSS ? // Add a new line between selectors newlineBetweenSelectors: false!true

//  before
[♥-component~="accordion"] {
    border-bottom: 1px solid $mine-shaft;
    .a--title {
        align-items: center;
        &:hover,
        &:focus {
            cursor: pointer;
        }
        &.isClose {
            &:before {
                @include triangle(20px, $alto, down);
            }
        }
    }
}

// after
[♥-component~="accordion"] {
    border-bottom: 1px solid $mine-shaft;

    .a--title {
        align-items: center;

        &:hover,
        &:focus {
            cursor: pointer;
        }

        &.isClose {
            &:before {
                @include triangle(20px, $alto, down);
            }
        }
    }
}

Thanks

jchouse commented 8 years ago

I'm sorry but my plugin is using CSSComb, and all the properties there. I don't add their own, and just use standard.

I think you can try {"lines-between-rulesets": 1} from there options

This is what you need?

tomagladiator commented 8 years ago

Thanks @jchouse, First, I used this site to generate my config : http://csscomb.com/config But the generated json doesn't have this option : lines-between-rulesets So I added it to the jSon, and nothing new happend

I find that in your package, atom-css-comb/node_modules/csscomb/lib/options/ we don't find https://github.com/csscomb/csscomb.js/blob/dev/src/options/lines-between-rulesets.js

jchouse commented 8 years ago

OK i'll try to up version, or find some other way to fix that

tomagladiator commented 8 years ago

Hi,

I write an issue in the repo of csscomb, I think they didn't update their NPM package : https://github.com/csscomb/csscomb.js/issues/482

mrmlnc commented 8 years ago

You can use npm install csscomb@4.0.0-alpha, but don't forget that this is alpha version.

Le-future commented 7 years ago

Hi guys,

I'm interested to get this option working as well, if a solution has been found since August, any help would be gladly appreciated 😃

jchouse commented 7 years ago

Guys I tried all the options but looks like that rule is not working. Even if you use csscomb clean. I don't know what to do with it. I'm waiting for your solutions. Or solving bugs https://github.com/csscomb/csscomb.js/issues/209