search

jchristn / SuperSimpleTcp

Simple wrapper for TCP client and server in C# with SSL support
MIT License
459 stars 95 forks source link

Future proof keepalive settings #147

Closed eatyouroats closed 2 years ago

eatyouroats commented 2 years ago

I noticed the keepalive settings wouldn't take effect if the library user targets NET6+. As per https://docs.microsoft.com/en-us/dotnet/standard/frameworks I've changed NET5_0 to NET5_0_OR_GREATER. This should future proof any NETx targets.

eatyouroats commented 2 years ago

Actually, I did an oopsie. I may have been too fast to hit the trigger on this. Do whatever with this, if you feel NET5_0_OR_GREATER is seen as a better fit, then by all means accept the PR or else please close... =)

jchristn commented 2 years ago

Thanks again @eatyouroats!

NuGet: https://www.nuget.org/packages/SuperSimpleTcp/2.6.1.4 Commit: https://github.com/jchristn/SuperSimpleTcp/commit/c2b36f42df8023f59376b279439aee52853a78ce

jchristn commented 2 years ago

Also I'm adding this to https://github.com/jchristn/cavemantcp and attributing to you in the commit and README