search

jchristn / WatsonWebsocket

A simple C# async websocket server and client for reliable transmission and receipt of data
MIT License
277 stars 53 forks source link

SetInvalidCertificateAcceptance not entering in if netframework. #105

Closed xbarra closed 1 year ago

xbarra commented 2 years ago

While looking for a workaround to #101, I noticed that in SetInvalidCertificateAcceptance https://github.com/jchristn/WatsonWebsocket/blob/affc63f0d72d97c61bab9b4e9a2cd97455975849/src/WatsonWebsocket/WatsonWsClient.cs#L569

when running in Net 6.0, the execution entered the if at line 575 (#if NET || NETSTANDARD || NETCOREAPP), but when running in Net Framework 4.8, it did not enter into the if at line 571 (#if NETFRAMEWORK).

jchristn commented 1 year ago

Hi! Sorry for the delay, I added Console.WriteLine("Hello!"); to both client and server and tested on .NET 4.6.1. It appears to enter for me. I'll test on .NET Framework 4.8 next.

image

jchristn commented 1 year ago

Hi, I just added targeting for net48 and tested, and it entered correctly. I'll publish a patch with the proper targeting momentarily. image

jchristn commented 1 year ago

Please reopen if the issue continues after upgrading to 4.0.4!

NuGet: https://www.nuget.org/packages/WatsonWebsocket/4.0.4 Commit: https://github.com/jchristn/WatsonWebsocket/commit/ae48a849d6549a93c3382da6887a29e6c2fff44c