search

jchristopher / attachments

[WordPress Plugin] Attachments allows you to simply append any number of items from your WordPress Media Library to Posts, Pages, and Custom Post Types
wordpress.org/extend/plugins/attachments/
GNU General Public License v2.0
239 stars 78 forks source link

PO file name and path for translating the Attachments plugin #46

Closed JoanBotella closed 11 years ago

JoanBotella commented 11 years ago

Hi Jonathan.

I'm trying to translate to spanish your plugin, but I don't know which name must have the PO file nor where to place it. I've tried creating it as .../wp-content/plugins/attachments/languages/attachments-es_ES.po and .../wp-content/plugins/attachments/languages/default-es_ES.po , but nothing happened. I can't find the load_plugin_textdomain call in your not deprecated plugin version.

Can you help me? I'll send you my translation when it's done, of course!

jchristopher commented 11 years ago

Hi there, yes I will definitely take a look at this, but might not be able to until the weekend, it might be an issue of my neglecting to tell WordPress where to find translations, but I'll have to double check when I can get a minute. Thank you so much for taking the time to translate!

jchristopher commented 11 years ago

Scratch that, I couldn't help but take a quick look and lo and behold I neglected to implement the languages directory processing. I've created a new branch, l10n, that has the proper implementation set up. If you'd like to check out that branch and submit your PO based on that, I'll get it into the next release!

JoanBotella commented 11 years ago

Sorry Jonathan, but I don't know how to use GitHub, I just registered for asking you this. I'm sending my translation to the e-mail address on your profile.

jchristopher commented 11 years ago

No problem, that sounds great—I'll include it in the branch and give you props in the next release. Thanks!

mleczakm commented 11 years ago

Hi! I've translated attachments to Polish You have one mistake, "Additinoal " :) i've added my translation files to github, it is my first time with this tool.

jchristopher commented 11 years ago

Fixed in https://github.com/jchristopher/attachments/commit/fa1fc6946192d3794cac24066c5f4f5455f43eb8

mleczakm commented 11 years ago

it is still not working for me, cause the should be only 'attachments/languages/' in textdomain ,and at mine wp it is '/home/user/domains/domain/html_public/wp-content/plugins/attachments/languages/'. it works when i changed it to 'attachments/languages/'.

jchristopher commented 11 years ago

This should be all set in the current version.