Equals in VariantMultiple seems to be incorrect.

jci-metasys / basic-services-dotnet

A simple client to access the most common services of the Metasys API (in the style of the old MSSDA)

https://jci-metasys.github.io/basic-services-dotnet/

BSD 3-Clause "New" or "Revised" License

3 stars 16 forks source link

Equals in VariantMultiple seems to be incorrect. #115

Closed michaelgwelch closed 3 years ago

michaelgwelch commented 3 years ago

If you have two instances and each has a null value for Values and the same Id you'd expect them to be considered equal. But this uses an exclusive or operator which results in a false being returned.

https://github.com/metasys-server/basic-services-dotnet/blob/31e7f5727feef654da7e43e193cfeff2e08c03c7/MetasysServices/Models/VariantMultiple.cs#L38-L40

michaelgwelch commented 3 years ago

I was wrong. Closing.