Code Review Standards/Pull Request Management

jcjohnson / torch-rnn

Efficient, reusable RNNs and LSTMs for torch

MIT License

2.5k stars 507 forks source link

Code Review Standards/Pull Request Management #183

Open dgcrouse opened 7 years ago

dgcrouse commented 7 years ago

We need a standard to review any PRs that come through, any suggestions?

I also move to reject all PRs in the backlog and encourage writers to resubmit. That way we can sort out what is actively being worked on and lessen the load.

ChrisCummins commented 7 years ago

Same as #184. It's not the PR author's fault if their code hasn't been reviewed, or now has merge conflicts. Rejecting PRs without good reason leaves a bad taste.

ChrisCummins commented 7 years ago

As for merging PRs, just do the usual. Make sure the code's been tested and reviewed, and if in doubt, err on the side of caution by tagging people to weigh in.

dgcrouse commented 7 years ago

Works for me.