jckleiner / notion-backup

Automatic Notion workspace backup to Google Drive, Dropbox, pCloud, Nextcloud or to your local machine.
90 stars 36 forks source link

pCloud integration #4

Closed marcelreppi closed 2 years ago

marcelreppi commented 2 years ago

Hello,

I have added support for pCloud. It has been tested locally and with GitHub Actions. All required documentation for getting OAuth setup etc. has been written.

Hope you are satisfied with the code! :)

jckleiner commented 2 years ago

Hey Marcel,

thank you very much again for this feature! I've just tested it a bit and everything works as expected. The code and your documentation looks also great.

It just bums me out that we can't make the auth process simpler. My goal is to keep things as simple as possible so that non-developers could also use this tool if they wanted to, but yeah, can't do anything about that.

marcelreppi commented 2 years ago

Hey :)

yay! I'm very happy you like it!

I totally understand what you mean and I also couldn't think of an easier way for now. I mean there is a paid version of this functionality (https://notionbackups.com/) which probably has the whole auth process automized and easy to use for non-tech people but really love and appreciate that this repo is free and open-source! Amazing initiative!

jckleiner commented 2 years ago

Yes, I saw that paid service and as far as I know you need to give them read/write access to your Notion account, which is scary (at least for me) since you can never be sure what they do with your data. Well, at least this can be an alternative.

I was also thinking about adding OneDrive support and maybe some kind of a support for dividing really large export files into smaller pieces so it won't cause any problems like here: https://github.com/jckleiner/notion-backup/issues/1#issuecomment-1228153951 and once those are implemented, i think there won't be much left to add, functionality wise. If you have any other ideas, please let me know :)

marcelreppi commented 2 years ago

You're absolutely right! That is scary!

OneDrive could be nice! I also thought about AWS S3 or other blob storage solutions. If I find some time some day I might look into it. The splitting seems like a great idea for such huge backup files!

Other than that there is still one open PR (https://github.com/jckleiner/notion-backup/pull/3) from me to support the use of Dropbox refresh tokens as an alternative to the short-lived access tokens.

I'll let you know if I have other ideas but for now this is an amazing tool!

marcelreppi commented 2 years ago

Btw I really don't know why but somehow this repository suddenly also has a pcloud-integration branch. I guess you can delete it since these changes were merged.