Stack client configuration doesn't accept Extensions (such as SCTP transport, etc)

GoogleCodeExporter commented 9 years ago

Q. What steps will reproduce the problem?

A.
1. Use the JDiameter 
2. Include below configurations in the jdiameter-client-config.xml

<Extensions>
  <-- Set SCTP classes as extension points for Connection and Network Guard -->
  <Connection value="org.jdiameter.client.impl.transport.sctp.SCTPClientConnection" />
  <NetworkGuard value="org.jdiameter.server.impl.io.sctp.NetworkGuard" />
 </Extensions>

3. Include jdiameter-api-1.5.10.0-build639.jar, 
jdiameter-impl-1.5.10.0-build639.jar and SCTP supporting jar.

4. Then stack the stack as a "diameter client".

Q. What is the expected output? What do you see instead?
A. The diameter stack has to come up.

Q. What version of the product are you using? On what operating system?
A. Mobicents Diameter 1.5.0.FINAL

Q. Please provide any additional information below.
A.
Below is the issue which we identified.

In the 'org.jdiameter.client' package 'XMLConfiguration' java class, in the 
'addExtension' method i had to replace 'add' method with 
'addInternalExtensions' method.

------------omitting other codes -------------------
changed from ---> 
if (nodeName.equals("MetaData")) {   
add(ExtensionPoint.InternalMetaData,getValue(c.item(i)));  }

changed to -> 
if (nodeName.equals("MetaData")) { 
addInternalExtension(ExtensionPoint.InternalMetaData,getValue(c.item(i)));      
            }
------------------------------------------------------

The addInternalExtension method i was able to get it from the 
org.jdiameter.server package.

Thanks and Best Regards,
Vinay R M.
vinay.munasraj@gmail.com

Original issue reported on code.google.com by raja.mun...@gmail.com on 5 Feb 2014 at 9:28

GoogleCodeExporter commented 9 years ago

Any update on this? I'm facing the same issue. 
Patch is attached, would be great if someone could check on this and commit it 
to HEAD.

Original comment by nils.so...@gmail.com on 7 Apr 2014 at 3:41

Attachments:

sctp-client.patch

GoogleCodeExporter commented 9 years ago

Thanks for reporting this. It seems indeed an issue. We don't use/test the 
client configuration that much, since it's perfectly possible to do it with 
only with server (and it's probably a good idea to "unify" these two into a 
single one) Still, if we have it we should make it work, will fix it 
accordingly.

Original comment by brainslog on 21 Aug 2014 at 11:35

Changed title: Stack client configuration doesn't accept Extensions (such as SCTP transport, etc)
Changed state: Accepted
Added labels: Component-DIAMETER-Stack, DIAMETER-1.6.0.FINAL, Roadmap-Fix

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 603d6305fe3a.

Original comment by brainslog on 21 Aug 2014 at 11:40

Changed state: Fixed

jcktej / jdiameter

Stack client configuration doesn't accept Extensions (such as SCTP transport, etc) #53