search

jckuester / awsls

A list command for AWS resources
MIT License
826 stars 53 forks source link

Adding a basic Dockerfile #19

Open mkohn opened 3 years ago

jckuester commented 3 years ago

Hi @mkohn,

sorry for my late reply here. Thanks for providing Docker support :+1:

Generally, I am not sure why using awsls via a container is useful since awsls comes as a compiled binary that runs natively on many platforms already. Can you help me understand your usecase?

If we add Docker support, I have the following suggestions. Let me know what you think:

  1. add the Docker image to the github registry via goreleaser like here https://github.com/rothgar/ssm-helpers/blob/master/.goreleaser.yml#L55
  2. Is it maybe sufficient to simply use a FROM scratch instead of an alpine base image like here https://github.com/rothgar/ssm-helpers/blob/master/Dockerfile.ssm-run?
mkohn commented 3 years ago

Personally, I dislike installing anything on my laptop directly. Additionally, I'm a consultant and work with many customers that require different versions of software, I got in the habit of running all software inside a docker container.

100% this container could be optimized to start from scratch. I was just starting with an MVP.

gliptak commented 3 years ago

many utilities started providing Docker images (with or without publishing). no need for install (and keeping up-to-date) and also allowing to run specific version are both very valuable with a Docker based setup

https://docs.github.com/en/packages/guides/configuring-docker-for-use-with-github-packages