How to add new resources

jckuester / awsweeper

A tool for cleaning your AWS account

Mozilla Public License 2.0

467 stars 45 forks source link

How to add new resources #108

Open rburchill opened 4 years ago

rburchill commented 4 years ago

Great tool, by far the best out the several I've used.

I'd like to add some more resources, starting with aws_athena_named_query but possibly more in the future.

Is this guide still relevant, https://github.com/jckuester/awsweeper/issues/21? It seems like you're working on a way to auto-generate the code. Would it be better to wait?

Thanks,

jckuester commented 4 years ago

Hi @rburchill :wave:

Great tool, by far the best out the several I've used.

Thanks you :-) As a little feedback, can you tell me what you like most about awsweeper in comparison to others?

Is this guide still relevant, #21?

I think it's time to close this issue; you are right, listing resources is (mostly) auto-generated with this generator and the Terraform AWS Provider handles the deletion part.

I just checked why the generator doesn't support aws_athena_named_query resources yet. The reason is that listing aws_athena_named_query resources depends on a given name of a aws_athena_workgroup resource. Resources that require input of another resource (anoher example: aws_s3_bucket_object depends on a given aws_s3_bucket name) are not yet supported; mainly, because I need to think of how this should look like from the user experience point of view. If you have any suggestions...

rburchill commented 4 years ago

can you tell me what you like most about awsweeper in comparison to others?

Sure, off the top of my head:

Supports a lot of resources
Uses terraform under the hood (I've used it before and really trust it)
Excluding resources by resource name/id is simple to configure
When I excluded an iam_user it also excluded it's IAM policy attachments, which is what I wanted (suggests implementation is well thought out)

So to describe my need a little, I do work in an AWS account for a week or two, and after that, I want to reset the account into a clean, pristine state. So in the Athena case, I'd be happy with a nuke from orbit remove all resources approach walking up the tree to delete all parent resources (unless explicitly excluded). This may not be what other users would want though...

jckuester commented 3 years ago

Thanks for your feedback, @rburchill. Very helpful to me. I definitely will think about and then work on an approach to handle resources that depend on other resources as one of the next features. I'll let you know what I come up with and probably will ask for your feedback again during that process.

ddvdozuki commented 2 years ago

Yea, this would be a killer feature, a "roll up" of all dependencies like the AWS Console does for VPC's and other resources.