search

jckuester / awsweeper

A tool for cleaning your AWS account
Mozilla Public License 2.0
469 stars 45 forks source link

Homebrew #26

Closed nysthee closed 4 years ago

nysthee commented 5 years ago

FYI I submitted a pr to get awsweeper into Homebrew: https://github.com/Homebrew/homebrew-core/pull/33984

nysthee commented 5 years ago

Unfortunately, they declined the PR. Maybe you could host the tap yourself? Then you could also use the bins directly instead of building it on install.

jckuester commented 5 years ago

Thanks :) Just 5 more stars to go and we can try again. I am also planning to implement new features to AWSweeper, which hopefully makes it more attractive. Just added a filter to filter by creation date and will do a --all-region flag soon to find resources in any region instead of just one.

nysthee commented 5 years ago

4 stars :)

jckuester commented 5 years ago

I guess, you can try again :) Please.

nysthee commented 5 years ago

Done: https://github.com/Homebrew/homebrew-core/pull/34429

Fingers crossed!

Ilselott commented 5 years ago

Hey, any news on the tap ? :)

aghassemlouei commented 4 years ago

Added a star and following up; anyone willing to try again?

andreamaruccia commented 4 years ago

Thanks :) Just 5 more stars to go and we can try again. I am also planning to implement new features to AWSweeper, which hopefully makes it more attractive. Just added a filter to filter by creation date and will do a --all-region flag soon to find resources in any region instead of just one.

how do you star it?

chenrui333 commented 4 years ago

I just filed a new PR to bring this utility tool to homebrew-core. :)

chenrui333 commented 4 years ago

I just merged and install the formula, which works. Issue is good to be closed now. 🎉 

$ brew install awsweeper
==> Downloading https://homebrew.bintray.com/bottles/awsweeper-0.10.1.mojave.bottle.tar.gz
Already downloaded: ==> Downloading https://homebrew.bintray.com/bottles/awsweeper-0.10.1.mojave.bottle.tar.gz
######################################################################## 100.0%
==> Pouring awsweeper-0.10.1.mojave.bottle.tar.gz
🍺  /usr/local/Cellar/awsweeper/0.10.1: 5 files, 189.7MB
jckuester commented 4 years ago

Awesome, @chenrui333. That's very cool, thank you so much! I'll close this issue once I've added homebrew to the install section of the README.

chenrui333 commented 4 years ago

Nice!

jckuester commented 4 years ago

@chenrui333, I just saw that you asked in the beginning of this thread

Maybe you could host the tap yourself?

Would hosting a third-party tap still make sense or doesn't it matter now where you added awsweeper to homebrew-core (which is very cool!). I am asking because I noticed the hard-coded version v0.10.1 in the homebrew PR. Does it mean for every new release of awsweeper, a new PR must opened with the homebrew-core repo?

chenrui333 commented 4 years ago

@chenrui333, I just saw that you asked in the beginning of this thread

Maybe you could host the tap yourself?

Would hosting a third-party tap still make sense or doesn't it matter now where you added awsweeper to homebrew-core (which is very cool!). I am asking because I noticed the hard-coded version v0.10.1 in the homebrew PR. Does it mean for every new release of awsweeper, a new PR must opened with the homebrew-core repo?

Since this is already in the homebrew-core, it would be taken where there is new release.

If there is any installation or test issue, we will open a new issue in here to discuss.

With that being said, there is no reason to maintain a separate tap (even though technically you can do that.)

Let me know if this makes more sense. :)

jckuester commented 4 years ago

I understand, so new versions of awsweeper are automatically picked up by homebrew-core. Thanks again for adding brew support.

chenrui333 commented 4 years ago

yeah, no problem, I might going to file another PR about setting up a new action of doing release automation for awsweeper tool :)