search

jckuester / awsweeper

A tool for cleaning your AWS account
Mozilla Public License 2.0
468 stars 45 forks source link

Add negation support for regex filters #48

Closed kadaan closed 4 years ago

jckuester commented 4 years ago

Looks good :+1: I think we should merge this next. Hope I get the build fixed soon. Can you add the NOT to the README?

kadaan commented 4 years ago

@jckuester Ready for review

jckuester commented 4 years ago

Still problems with the CI build (https://gitlab.com/jckuester/awsweeper/-/jobs/289751538): I set the docker image to 1.12 instead of latest, which helped with the previous problem, but now the make generate phase fails.

Will try to reproduce that locally with by using a golang Docker container.

jckuester commented 4 years ago

Ran integration tests locally for now (-> all green) and released the newest changes: https://github.com/cloudetc/awsweeper/releases/tag/v0.3.3

Thanks :+1: