search

jckuester / awsweeper

A tool for cleaning your AWS account
Mozilla Public License 2.0
480 stars 46 forks source link

aws_cloudtrail support #96

Closed aghassemlouei closed 4 years ago

aghassemlouei commented 4 years ago

Description: Adding support for aws cloudtrail trail deletion

Justification:

  1. Expand support for service coverage
  2. Ensure s3 buckets can be deleted when cloudtrail is logging to s3
  3. Resolves #94
aghassemlouei commented 4 years ago

Apologies for the incredibly poor variable names but it's not entirely clear what the convention is and I'm 100% down for any modifications. Attempted to follow instructions on #21 but it seems like it's missing a step or two but I was able to kind of follow along by referencing a few other pull requests that had made their way to master. Might be worth converting the issue into a contributing guide?

Unfortunately I still managed to miss something with the travis build output but I think it may be unrelated as my other seemingly innocuous pull request #95 also seemed to fail? Unfortunately the integration tests are beyond my capabilities and bandwidth but I promise I'll give it a shot one day!

jckuester commented 4 years ago

Hi @aghassemlouei :wave:

Thanks for the PR, I gave you some feedback. I can take care of the integration test once you are done.

A contribution guide is probably a good idea. However, I can give you already a sneak peek into my plans of auto-generating the support for resources (https://github.com/jckuester/awsls). I auto-generated already list functions for over 200 resources and will integrate the feature soon into awsweeper. Stay tuned :smiley:

aghassemlouei commented 4 years ago

Thank you for taking the time to show and suggest the modifications. If you could integrate the awsls utility to feed this and near instantly expand the service coverage that'd be amazing!

jckuester commented 4 years ago

Thanks @aghassemlouei for the quick turn-around on this PR. Merged!

jckuester commented 4 years ago

FYI, here are the tests I created for this PR: https://github.com/cloudetc/awsweeper/pull/99