search

jclarke0000 / MMM-OpenWeatherForecast

Magic Mirror weather module using OpenWeather API
42 stars 25 forks source link

fix: use openweather api 3.0 #29

Open xmanwms95 opened 2 months ago

xmanwms95 commented 2 months ago

openweather api 2.5 will be deprecated in June 2024 https://openweathermap.org/one-call-transfer

KristjanESPERANTO commented 2 months ago

@xmanwms95 Since @jclarke0000 has not responded to issues for a long time and generally seems to have no activity on his GitHub account, it might be a good idea to continue maintaining the module in a fork. Would you be willing to do that?

BKeyport commented 2 months ago

Please do that, xman. If J. Clarke comes back, he can always pick it back up. In the meantime, we've got fixes.

Tom-Hirschberger commented 1 month ago

Sh... Saw this pull request to late and made a fork which allows to configure the URL as a config option.

KristjanESPERANTO commented 1 month ago

Sh... Saw this pull request to late and made a fork which allows to configure the URL as a config option.

Even better :+1: Can we switch to your fork?

Tom-Hirschberger commented 1 month ago

Sure if you like. But i can only guarantee for basic support. I use the module by my self and will try to keep it running. But I am very busy with my new born twins at the moment.

Make sure to set the new base url in the config as the fork still uses the 2.5 API in default. The instructions are part of the updated Readme.

lxne commented 1 month ago

But I am very busy with my new born twins at the moment.

Congrats! That is definitely a challenge. Best wishes Alex

KristjanESPERANTO commented 1 month ago

Basic support would be awesome. But even if you can not provide support, a working fork would already be a good step ahead.

Would be nice if you would accept the change of the clone command: https://github.com/Tom-Hirschberger/MMM-OpenWeatherForecast/pull/1

P.S.: Congratulations on the twins! 👍😀

Tom-Hirschberger commented 1 month ago

Thanks and accepted