search

jclouds / legacy-jclouds-cli

https://jclouds.apache.org
Apache License 2.0
17 stars 5 forks source link

Allow specifying extra options to the Java cmdline. #39

Closed gaul closed 11 years ago

gaul commented 11 years ago

Among other things, this enables callers to configure HTTP proxy via environment variables.

demobox commented 11 years ago

Any reason this option was not added to the Windows shell.bat file? The "exec" line of the Unix and Windows versions seems to be diverging a bit...

exec $JAVA $JAVA_OPTS ${EXTRA_JAVA_OPTS:-} -Dkaraf.instances="${KARAF_HOME}/instances" -Dkaraf.home="$KARAF_HOME" -Dkaraf.base="$KARAF_BASE" -Djava.io.tmpdir="$KARAF_DATA/tmp" -Dlog4j.configuration=file://$KARAF_BASE/etc/log4j.properties $KARAF_OPTS $OPTS -classpath "$CLASSPATH" org.jclouds.cli.runner.Main "$@"

vs.

"%JAVA%" %JAVA_OPTS% %OPTS% -classpath "%CLASSPATH%" -Dkaraf.instances="%KARAF_HOME%\instances" -Dkaraf.home="%KARAF_HOME%" -Dkaraf.base="%KARAF_BASE%" -Djava.io.tmpdir="%KARAF_DATA%\tmp" -Dlog4j.configuration="file:///%KARAF_BASE%\etc\java.util.logging.properties" %KARAF_OPTS% org.jclouds.cli.runner.Main %ARGS%
demobox commented 11 years ago

I should add: are ${EXTRA_JAVA_OPTS:-} and %OPTS% intended to be the same thing? If so, perhaps align naming?

gaul commented 11 years ago

@demobox Sorry this is my mistake; I did not even realize jclouds-cli had a Windows wrapper! I agree that we should be consistent. I do not know the best way to proceed with this; I cannot test any modifications I make to Windows source.

demobox commented 11 years ago

I cannot test any modifications I make to Windows source.

I can try to help with that (although I still hesitate to say something like "hail to my Dell work laptop" ;-)). Any specific test case you'd like carried out?

Admittedly, obviously, this is not exactly a scalable solution :-( Do you have a Windows VM running anywhere?