search

jclouds / legacy-jclouds-labs

https://jclouds.apache.org
0 stars 18 forks source link

Initial support for Google Cloud Storage #18

Closed andreaturli closed 11 years ago

andreaturli commented 11 years ago

This is an initial support Google Cloud Storage (GCS) JSON API.

To simplify the review process, this PR contains only the initial scaffolding of the GCS provider and some domain objects related to the buckets (with unit tests).

As I don't have enough rights on this repo, I can't explicitly assign reviewers. From IRC I know @mattstep @andrewgaul @adriancole should be interested on looking into it. Thanks!

codefromthecrypt commented 11 years ago

I'd add in at least one api command, such as list buckets, and trim domain classes that are not yet referenced for later pull requests.

andreaturli commented 11 years ago

@adriancole I've added BucketApi with CRUD to have a meaningful LiveTest.

mattstep commented 11 years ago

Still reviewing, do not merge until i've fully reviewed.

mattstep commented 11 years ago

Code style seems off

mattstep commented 11 years ago

Please fix the formatting and resubmit.

andreaturli commented 11 years ago

@mattstep wrt your comment on GoogleCloudStorageConstants, they are used in more than one place, so I think it makes sense to keep them separated.

mattstep commented 11 years ago

Constants belong in organized places, having a "dump all" class for constants is useless. Find a good home for them so that they can be shared across classes. "Constants" is not a good home.

codefromthecrypt commented 11 years ago

choosing to close this one out as folks at google suggest the XML api is the encouraged and supported binding. https://developers.google.com/storage/docs/developer-guide

I suspect most of this code could be renamed and put to use as another api such as BigQuery https://developers.google.com/bigquery/docs/reference/v2/