jclouds / legacy-jclouds-labs

https://jclouds.apache.org
0 stars 18 forks source link

Unasync google and oauth #55

Closed codefromthecrypt closed 11 years ago

codefromthecrypt commented 11 years ago

The primary goal of this change was to remove the async interfaces of the oauth and google-compute-engine apis. Along the way, I noticed some arbitrary differences in how gce live tests operate vs other providers and removed them. In fact, the live tests didn't pass at all, partly due to bit rot in test config.

I didn't have time to unwind oauth's very complicated test structure, so that's as-is.

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #85 SUCCESS This pull request looks good (what's this?)

codefromthecrypt commented 11 years ago

tested fine, except I reached my quota :)

Failed tests:   testConcurrentUseOfComputeServiceToCreateNodes(org.jclouds.googlecomputeengine.compute.GoogleComputeEngineServiceLiveTest): java.lang.IllegalStateException: Could not create network, operation failedOperation{kind=compute#operation, id=18202428030375227106, name=operation-1367078309318-4db59b900f699-1186da3a, selfLink=https://www.googleapis.com/compute/v1beta13/projects/jclouds-dev/operations/operation-1367078309318-4db59b900f699-1186da3a, name=operation-1367078309318-4db59b900f699-1186da3a, targetLink=https://www.googleapis.com/compute/v1beta13/projects/jclouds-dev/networks/jclouds-twin0, status=DONE, user=107648139589@developer.gserviceaccount.com, progress=100, insertTime=Sat Apr 27 08:58:29 PDT 2013, startTime=Sat Apr 27 08:58:29 PDT 2013, httpError={statusCode=403, message=FORBIDDEN, headers={}}, operationType=insert, errors=[Error{code=QUOTA_EXCEEDED, message=Quota 'NETWORKS' exceeded.  Limit: 5.0}]}

Tests run: 57, Failures: 1, Errors: 0, Skipped: 10
codefromthecrypt commented 11 years ago

fixed in latest commit. thx!

nacx commented 11 years ago

+1

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #88 SUCCESS This pull request looks good (what's this?)