Unasync Abiquo - Githubissues

jclouds / legacy-jclouds-labs

https://jclouds.apache.org

0 stars 18 forks source link

Unasync Abiquo #81

Closed nacx closed 11 years ago

nacx commented 11 years ago

Removed async Abiquo APIs.

Removed all async api classes.
Refactored strategies to avoid using the async apis.
Added a method to the strategies to allow users pass their own ExecutorService.
Removed references to awaitCompletion and use Guava Future helpers.
Renamed classes to remove "async" references from their name.

codefromthecrypt commented 11 years ago

replacing internal use of ApiContext<Api> with Api would be nice, but not urgent and should wait until ASF imho.

codefromthecrypt commented 11 years ago

thanks for removing 3k lines, btw!

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #86 SUCCESS This pull request looks good (what's this?)

nacx commented 11 years ago

Removing the references to the context will require a deeper refactor. I'll address that once in ASF. I'm going to squash the commits so this can be properly merged.

codefromthecrypt commented 11 years ago

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #87 SUCCESS This pull request looks good (what's this?)

codefromthecrypt commented 11 years ago

don't forget to raise a cherry-pick for this against master, as it is easy to get out of sync.