search

jclouds / legacy-jclouds-labs

https://jclouds.apache.org
0 stars 18 forks source link

refactored to use pems, added retry logic to poll while system is reconfiguring #94

Closed dkoper closed 11 years ago

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #107 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #108 FAILURE Looks like there's a problem with this pull request (what's this?)

demobox commented 11 years ago

@dkoper Still looks like this is failing to compile Any idea what might be going on there..?

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #110 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #111 SUCCESS This pull request looks good (what's this?)

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #114 SUCCESS This pull request looks good (what's this?)

buildhive commented 11 years ago

Adrian Cole » jclouds-labs #115 SUCCESS This pull request looks good (what's this?)

codefromthecrypt commented 11 years ago

out of courtesy of the review team, please don't submit pull requests that have so many random things in it. half these commits I could have merged, but I can't as they are wound in the middle of some that need work. Try to split out the PEM stuff in isolation so you can complete that. The other stuff is pretty easy to merge, but distracting to have here. make sense?

codefromthecrypt commented 11 years ago

thanks for migrating the other stuff into another PR. I can't review for a while, but this makes it a lot easier.

dkoper commented 11 years ago

Sure. If I had known how to do this properly with different branches for each PR, I would have done that in the 1st place :) I've been able to separate the async stuff from the pem refactoring, they're somehow deeply intertwined.

codefromthecrypt commented 11 years ago

rename this bad-boy to unasync-fgcp?

dkoper commented 11 years ago

Everything's extracted to the referenced PRs. Thanks for watching.