search

jclouds / legacy-jclouds

https://jclouds.apache.org
466 stars 217 forks source link

Remove duplicate Utils getters #1535

Closed gaul closed 11 years ago

gaul commented 11 years ago

Rename callers as required.

codefromthecrypt commented 11 years ago

ick I don't like this one. getThis.getThat is kindof annoying.

gaul commented 11 years ago

Happy to go the other way on this, but I would like to get rid of the duplicates. Do you prefer utils().httpClient() over getUtils().getHttpClient(), or some other combination?

codefromthecrypt commented 11 years ago

if it is important to remove one, then I'd retain utils().httpClient() just make sure this doesn't screw up dynamic languages like clojure.

On Fri, Apr 12, 2013 at 3:39 PM, Andrew Gaul notifications@github.comwrote:

Happy to go the other way on this, but I would like to get rid of the duplicates. Do you prefer utils().httpClient() over getUtils().getHttpClient(), or some other combination?

— Reply to this email directly or view it on GitHubhttps://github.com/jclouds/jclouds/pull/1535#issuecomment-16321277 .

demobox commented 11 years ago

Do you prefer utils().httpClient()

+1

buildhive commented 11 years ago

Adrian Cole » jclouds #1239 SUCCESS This pull request looks good (what's this?)

cloudbees-pull-request-builder commented 11 years ago

jclouds-java-7-pull-requests #364 SUCCESS This pull request looks good

codefromthecrypt commented 11 years ago

I'd prefer to remove utils completely than deprecate it piece by piece.

On Friday, April 12, 2013, CloudBees pull request builder plugin wrote:

jclouds-java-7-pull-requests #364https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/364/SUCCESS This pull request looks good

— Reply to this email directly or view it on GitHubhttps://github.com/jclouds/jclouds/pull/1535#issuecomment-16322576 .

buildhive commented 11 years ago

Adrian Cole » jclouds #1240 FAILURE Looks like there's a problem with this pull request (what's this?)

codefromthecrypt commented 11 years ago

Anyway just merge this just saying it would be easier to deprecate the class as there's no value in us doing all these hooks in utils since we expose ContextBuilder buildInjector

On Friday, April 12, 2013, BuildHive wrote:

Adrian Cole » jclouds #1240https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1240/FAILURE Looks like there's a problem with this pull request (what's this?) https://www.cloudbees.com/what-is-buildhive

— Reply to this email directly or view it on GitHubhttps://github.com/jclouds/jclouds/pull/1535#issuecomment-16322801 .

codefromthecrypt commented 11 years ago

looks like it needs a rebase or something...

cloudbees-pull-request-builder commented 11 years ago

jclouds-java-7-pull-requests #365 SUCCESS This pull request looks good