search

jcmcbeth / Planets

2 stars 1 forks source link

changed do_propeganda #26

Closed svenkat19 closed 3 years ago

svenkat19 commented 3 years ago

Went through all the .c and .h files in src and updated do_propeganda to do_propaganda. In the description, you had mentioned to change the "commands.dat" file as well but I was unable to find it. I went through all the .dat files and found only one of them needed the change. Let me know if I have missed out on anything. Cheers!!

jcmcbeth commented 3 years ago

Looks good at first glance. I did mix up that do_propaganda is a skill and not a command, so skills.dat is probably the correct place.

I will test this later and merge the PR if there are no issues found.

Thanks for looking into this.

jcmcbeth commented 3 years ago

@svenkat19 Turns out that propaganda is spelled wrong everywhere. That's my mistake for not checking other places since I was thinking it was a command instead of a skill.

image

Could you also update those references too for this? Also, there is one additional reference to "progeganda" in skills.dat.

svenkat19 commented 3 years ago

I have changed the spelling error in all the above mentioned files. I accidently removed the assignment as well😬. Anyway, please let me know if there are anymore changes😁.