Closed er9 closed 4 years ago
Hello @er9! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
tests/test_tensor/test_tensor_core.py
:Line 231:34: E231 missing whitespace after ',' Line 231:61: E231 missing whitespace after ':' Line 231:64: E231 missing whitespace after ',' Line 231:74: E231 missing whitespace after ':' Line 231:77: E231 missing whitespace after ',' Line 231:80: E501 line too long (81 > 79 characters) Line 232:34: E231 missing whitespace after ',' Line 232:36: E231 missing whitespace after ',' Line 232:38: E231 missing whitespace after ',' Line 233:35: E231 missing whitespace after ',' Line 233:39: E231 missing whitespace after ',' Line 233:43: E231 missing whitespace after ',' Line 235:28: E201 whitespace after '(' Line 235:45: E231 missing whitespace after ',' Line 235:49: E203 whitespace before ',' Line 235:58: E202 whitespace before ')' Line 238:43: E231 missing whitespace after ':' Line 238:46: E231 missing whitespace after ',' Line 240:35: E231 missing whitespace after ',' Line 240:39: E231 missing whitespace after ',' Line 242:40: E231 missing whitespace after ',' Line 245:43: E231 missing whitespace after ':' Line 245:46: E231 missing whitespace after ','
Merging #63 into develop will decrease coverage by
1.07%
. The diff coverage is96.00%
.
@@ Coverage Diff @@
## develop #63 +/- ##
===========================================
- Coverage 87.39% 86.31% -1.08%
===========================================
Files 32 32
Lines 8686 8711 +25
===========================================
- Hits 7591 7519 -72
- Misses 1095 1192 +97
Impacted Files | Coverage Δ | |
---|---|---|
quimb/tensor/tensor_core.py | 91.15% <96.00%> (+0.07%) |
:arrow_up: |
quimb/tensor/optimize_autograd.py | 37.17% <0.00%> (-50.27%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update aecb30a...56d3aaa. Read the comment docs.
Nice, thanks for the contribution!
added an 'unfuse' method that changes the shape of specified inds. Positions of new inds group are in the position of the old ind. Ordering and shape of within new inds group is specified in the input parameters 'unfuse_map' and 'shape_map'.