jcmoraisjr / haproxy-ingress

HAProxy Ingress
https://haproxy-ingress.github.io
Apache License 2.0
1.03k stars 272 forks source link

Need way to notify Top-Level Load Balancer of shutdown during a upgrade on /healthz endpoint #1052

Open bsteve99 opened 9 months ago

bsteve99 commented 9 months ago

The ingress needs to notify our load-balancer that sits above our k8 cluster on the /healthz endpoint that we are shutting down or upgrading for seamless/graceful upgrades.

Our Load Balancer sends to our configured pool of k8 worker nodes on a NodePort.

I was thinking about configuring a monitor-fail to do this, but somethings not right about it.

This was said on slack.

"but I see we can make some improvements on how haproxy itself notifies a listener, by e.g. removing the monitor uri during a grace period, between the removing of a pod and the pod being effectively removed."

bsteve99 commented 8 months ago

I think if the controller itself had a /health endpoint; that would work also, that could return a 504 during graceful shutdown....