search

jcmturner / gokrb5

Pure Go Kerberos library for clients and services
Apache License 2.0
725 stars 248 forks source link

Fix KDCREP verification #501

Closed sokoide closed 1 year ago

sokoide commented 1 year ago

The PR fixes SPNEGO failure when TGS_REP only has IPv4 #500. The original code confirms all IP addresses in TGS_REP and TGS_REQ which fails when TGS_REP only has IPv4 and TGS_REQ had both IPv4 and IPv6.

The change confirms all IP addresses in TGS_REP are included in TGS_REQ, but not checking the equality.

sokoide commented 1 year ago

Hello @jcmturner, would you advise on how to handle this issue or for the PR? Thank you!

sokoide commented 1 year ago

Hello @jcmturner, would you kindly take a look? Thx!

jcmturner commented 1 year ago

Thanks for the contribution!