jcmturner / gokrb5

Pure Go Kerberos library for clients and services
Apache License 2.0
717 stars 243 forks source link

Config: handle dns_canonicalize_hostname=fallback setting #523

Open yann-soubeyrand opened 1 year ago

yann-soubeyrand commented 1 year ago

Hello,

This PR adds support for the dns_canonicalize_hostname=fallback setting, but it’s a breaking change. I saw that there already is a candidateV9 branch, but it doesn’t seem to be up to date with the latest v8 changes. I find it difficult to maintain several major versions using subdirectories instead of branches. I understand that it was a way to maintain backward compatibility for people not using Go modules, however it seems that Go modules have done their way and it may not be relevant anymore. That’s why I started this new branch where I put the v8 at the root of the repository and then cherry-picked your v9 changes on top of it before adding my commit. What do you think?