search

jcnelson / vdev

A device-file manager for *nix
GNU General Public License v3.0
101 stars 13 forks source link

Small nuisance with /run/vdev #49

Open onimatrix81 opened 9 years ago

onimatrix81 commented 9 years ago

In /etc/vdev/vdevd.conf I left pidfile to be written to /run/vdev/vdev.pid. As good of a file as any afaik. Whose responsibility however is it to create the directory, because vdevd just errors out if it doesn't exist?

jaromil commented 9 years ago

this is a good behavior across *nix daemons, creating non existing directories may introduce security rirks. It is the responsibility of the caller to create them.

fbt commented 9 years ago

Agreed, I have no problems with initscripts creating directories.

jcnelson commented 9 years ago

@onimatrix81 The init script should make /run/vdev. Looks like the included init script does not do this; I just pushed a patch to make it do so.

onimatrix81 commented 9 years ago

Yeah jcnelson. Heh, I had no idea about that. It was "an issue" when I kept starting vdevd manually. My OpenRC init script does this too as Jaromil abd fbt cleared it out that this was desired behaviour.