jcnelson / vdev

A device-file manager for *nix
GNU General Public License v3.0
101 stars 13 forks source link

libudev-compat: fcntl definitions missing on older glibc #62

Open tilt12345678 opened 8 years ago

tilt12345678 commented 8 years ago

building libudev-compat fails on amd64 libc 2.13 (wheezy) with MAX_HANDLE_SZ undefined struct file_handle resolves to incomplete type this is just jused for the definition of file_handle_union, which in turn appears not to be used in libudev-compat. i got it to compile anyhow by adding the missing definitions according to a libc version 2.19 fcntl bits/fcntl-linux.h see 7104a1bbb4c33019fe71b211458e8fe6c2fde4d2 for details hooray ;-) but probably it was smarter to just delete the offending code

jcnelson commented 8 years ago

Heh, this is because libudev-compat was forked from systemd's libudev 219, so it doesn't surprise me that there are bits that won't compile on Wheezy. If you send me your diff as a PR I'd be happy to merge it :).

In general, I'm in favor of making changes like the one you proposed instead of removing code, since I'd like to keep libudev-compat's code as close as possible to libudev's. This makes it easier for me to keep libudev-compat's API in sync with libudev's.