jcoglan / restore

Simple remoteStorage server written in Node.js
293 stars 27 forks source link

Fix compatibility problems with client lib 0.8.1 #11

Closed clochix closed 10 years ago

clochix commented 10 years ago

See https://github.com/remotestorage/spec/issues/23 : respond with 304 instead of 412 when the If-None-Match condition on a GET request fails. Also, allow the use of ETags.

jcoglan commented 10 years ago

I've fixed the s/412/304/ problem for conditional GET. Can you be more specific about the etag problem? The server emits etags and accepts the If-Match and If-None-Match headers for conflict checking.

jcoglan commented 10 years ago

Ah, sorry, I didn't realize this was a PR instead of an issue, my mistake. Most of this has been fixed in other commits, I'll add the Access-Control-Expose-Header. Thanks!