search

jcoglan / restore

Simple remoteStorage server written in Node.js
293 stars 27 forks source link

If-Match and If-None-Match parsing incorrect #20

Closed ntuckerxx closed 10 years ago

ntuckerxx commented 10 years ago

Storage.prototype.getVersion passes the header value directly to parseInt, but HTTP specifies that these header values are quoted entity-tags (see http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.24 and http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.11), so the parsing is failing and returning NaN.

jcoglan commented 10 years ago

This should be fixed by https://github.com/jcoglan/restore/commit/81f34db526896724f9aae8d67c9459f8ee574421.