search

jcoglan / restore

Simple remoteStorage server written in Node.js
293 stars 27 forks source link

resolve jshint warnings #21

Closed silverbucket closed 9 years ago

silverbucket commented 9 years ago

Hi James, I'll be working on using restore for another project and although some of the changes I make wouldn't make sense to backport, I would like to submit other things upstream and hope you're open to that.

This is just a few missing semicolons and undefined vars. I will be updating restore to be compliant with the latest webfinger spec soon.

silverbucket commented 9 years ago

That's odd that tests are failing, they pass when I run them locally, and nothing I did should have broken anything. Is there something more to the test process on travis?

raucao commented 9 years ago

@silverbucket Check out the details. They pass on node <= 0.10 and only fail on 0.11.

silverbucket commented 9 years ago

@jcoglan are they all supposed to be passing with v0.11?

galfert commented 9 years ago

The last build for the master branch was green for all three node versions:

https://travis-ci.org/jcoglan/restore/builds/27265830

silverbucket commented 9 years ago

@galfert yeah I saw that too. it doesn't really make any sense though. How could a few semicolons and undefined var fixes be causing a complete failure in v0.11 ? you'd think jshint and node v0.11 play nice togehter.

silverbucket commented 9 years ago

I just installed node v0.11.13 on my machine, and all restore tests pass. I guess this is a travis issue?

silverbucket commented 9 years ago

closing in favor of #23