search

jcoglan / restore

Simple remoteStorage server written in Node.js
293 stars 27 forks source link

Update webfinger endpoint #23

Closed silverbucket closed 9 years ago

silverbucket commented 9 years ago

This is some work I did a few weeks ago to make the webfinger endpoint compliant with the approved spec. XRD is deprecated completely, however I left it in and just made the default JRD.

Also the official endpoint is /.well-known/webfinger. This pull request includes some jshint updates and deprecates pull request #21

raucao commented 9 years ago

Still failing with 0.11 by the way. Not sure if non-stable node releases are important, though.

silverbucket commented 9 years ago

Looks like the url.parse function was returning null instead of an empty object when populating this.params. This was causing errors in other parts of the code that were accessing this.params.resource and this.params.oauth_token. Must be something different in it's behavior when running in the node v0.11 environment.

All tests passing!

jcoglan commented 9 years ago

@silverbucket Sorry again for the delay, I'm trying to catch up. I've merged this but I've made some tweaks to it to maintain backward compatibility, so that I've kept the test you added but kept the existing tests unchanged.