search

jcoglan / restore

Simple remoteStorage server written in Node.js
293 stars 27 forks source link

Update reStore to handle new way of handling ejs params, and peg dependency versions for reference. #29

Closed silverbucket closed 9 years ago

silverbucket commented 9 years ago

resolves #28

raucao commented 9 years ago

Tests are failing.

silverbucket commented 9 years ago

Would be cool if travis would notify the pull-requester when this happens.

silverbucket commented 9 years ago

This is npm weirdness:

npm ERR! Error: No compatible version found: ejs@'^2.0.8'

npm ERR! Valid install targets:

npm ERR! ["0.0.1","0.0.2","0.0.3","0.0.4","0.1.0","0.2.0","0.2.1","0.3.0","0.3.1","0.4.0","0.4.1","0.4.2","0.4.3","0.5.0","0.6.0","0.6.1","0.7.0","0.7.1","0.7.2","0.8.0","0.8.1","0.8.2","0.8.3","0.8.4","0.8.5","0.8.6","0.8.8","1.0.0","2.0.2","2.0.3","2.0.4","2.0.5","2.0.6","2.0.7","2.0.8"]

Clearly, 2.0.8 is listed, but somehow that doesn't work? Also it's only for the node v0.8 branch. Not v0.10 or v0.11

raucao commented 9 years ago

That one's outdated. You can remove it here: https://github.com/jcoglan/restore/blob/master/.travis.yml#L4-L6

raucao commented 9 years ago

Would be good if we can have the @5apps master be a clean master branch with merged PRs, while @jcoglan is on break, so he can (hopefully) merge all of our fixes back to his repo when he comes back.

jcoglan commented 9 years ago

I've just merged your commits, thanks :)